Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[image_picker] Fix camera alert localization analyzer warning #3939

Merged
merged 2 commits into from
May 20, 2021
Merged

[image_picker] Fix camera alert localization analyzer warning #3939

merged 2 commits into from
May 20, 2021

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented May 19, 2021

Fixes flutter/flutter#82959. Warning introduced in #3881. There are already tests for this failing on master (I'm not sure why it succeeded on presubmit, GCC_TREAT_WARNINGS_AS_ERRORS is set to YES).

https://api.cirrus-ci.com/v1/task/6726759736410112/logs/xctest.log

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
  • I signed the [CLA].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@jmagman jmagman requested a review from stuartmorgan May 19, 2021 23:32
@jmagman jmagman requested a review from cyanglaz as a code owner May 19, 2021 23:32
@jmagman jmagman self-assigned this May 19, 2021
@google-cla google-cla bot added the cla: yes label May 19, 2021
stuartmorgan
stuartmorgan approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the format check is happy.

(I wonder why we're showing native UI instead of returning an error to Dart)

@jmagman
Copy link
Member Author

jmagman commented May 20, 2021

This fixed the targeted analyzer warning, though still seeing this video_player warning since it's being pulled in as
dependency. flutter/flutter#82958

https://cirrus-ci.com/task/6418550869983232?logs=xctest#L2964

@jmagman jmagman added waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. and removed waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. labels May 20, 2021
@jmagman
Copy link
Member Author

jmagman commented May 20, 2021

still seeing this video_player warning

Will be fixed by #3940.

@jmagman
Copy link
Member Author

jmagman commented May 20, 2021

I'm going to merge this to try to fix more issues blocking the submit queue. The last error in the failing test is really from video_player and will be fixed by #3940.

@jmagman jmagman merged commit a83d8ef into flutter:master May 20, 2021
@jmagman jmagman deleted the image-picker-localize branch May 20, 2021 00:54
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 20, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 20, 2021
@engine-flutter-autoroll
a83d8ef [image_picker] Fix camera alert localization analyzer warning (…
d063782 
…flutter/plugins#3939)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 20, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 20, 2021
@engine-flutter-autoroll
a83d8ef [image_picker] Fix camera alert localization analyzer warning (…
90b9326 
…flutter/plugins#3939)
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@jmagman @fotiDim
[image_picker] Fix camera alert localization analyzer warning (flutte…
3139ab5 
…r#3939)
jolmiracle pushed a commit to miracle-as/webview_flutter that referenced this pull request Sep 24, 2021
@jmagman @jolmiracle
[image_picker] Fix camera alert localization analyzer warning (flutte…
c4e1342 
…r#3939)

# Conflicts:
#	packages/image_picker/image_picker/pubspec.yaml
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stuartmorgan stuartmorgan stuartmorgan approved these changes

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

Assignees

@jmagman jmagman

Labels
cla: yes p: image_picker platform-ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

image_picker analyzer warnings: User-facing text should use localized string macro
2 participants
@jmagman @stuartmorgan